feat: ability to generate content.json in multiple languages#48
feat: ability to generate content.json in multiple languages#48MSakamaki wants to merge 3 commits intotypebytes:masterfrom
Conversation
|
Hey there! I would really like to come back to i18n and I appologize for not showing up for so long. I was quite busy with work. So this is step 1 of getting translations in. Can you please rebase this branch on latest master? Right now it has conflicts and to continue with this we need to resolve these conflicts. For step 2 I would also suggest to use Do you have experience with transloco already or would you mind divining into it? Otherwise I'd pull in @maartentibau for the transloco part. He's interested as well in contributing. Does this PR work for transloco as well? |
|
@d3lm Unfortunately I don't have transloco experience, but now I will learn and challenge transloco! We will update step1 in the next few days, please wait. |
|
Hi @MSakamaki this might maybe help you. https://gist.github.com/maartentibau/8f2c1c7bd64831520bb63028bba314ca It is more or less the basic setup of Transloco when using a custom loader. For starters, if you have ever worked with Docs can be found here: https://netbasal.gitbook.io/transloco/ If you need Transloco as a dependency for your unit tests, in 99% of the cases it's enough to just add |
|
Yay! Super happy to hear you wanna continue with this PR. Thanks so much. This will be a great addition. |
6b79c1b to
12bb202
Compare
|
@d3lm @maartentibau Since we confirmed that this could be integrated without problems, we will update the procedure to suit transloco. Thanks! |
TRANSLATION.md
Outdated
| The following tasks are required to add a new language. | ||
| [See available code here](https://github.com/angular/angular/tree/master/packages/common/locales). | ||
|
|
||
| - Add word transration file in `src/assets/i18n/[lang-code].json`. |
There was a problem hiding this comment.
Thanks @maartentibau, I fixed it! (and unknown space)
There was a problem hiding this comment.
Thanks @maartentibau for keeping an eye on this too! 🙏
#45 step 1